added support of durable delete #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijusti
reviewed
Dec 13, 2023
...ike/src/main/java/com/playtika/testcontainer/aerospike/AerospikeExpiredDocumentsCleaner.java
Outdated
Show resolved
Hide resolved
...ike/src/main/java/com/playtika/testcontainer/aerospike/AerospikeExpiredDocumentsCleaner.java
Show resolved
Hide resolved
wolfchkov
force-pushed
the
feature/durable-delete-support
branch
from
88de4e9 to
bf262a6
Compare
ijusti
reviewed
Dec 13, 2023
| @@ -11,7 +11,7 @@ | |||
| @ConfigurationProperties("embedded.aerospike") | |||
| public class AerospikeProperties extends CommonContainerProperties { | |||
|
|
|||
| static final String BEAN_NAME_AEROSPIKE = "aerospike"; | |||
| public static final String BEAN_NAME_AEROSPIKE = "aerospike"; | |||
There was a problem hiding this comment.
why do you need public? I dont see usages
There was a problem hiding this comment.
usage on other library
...src/test/java/com/playtika/testcontainer/aerospike/AerospikeExpiredDocumentsCleanerTest.java
Outdated
Show resolved
Hide resolved
ijusti
previously approved these changes
Dec 13, 2023
…sCleaner, and the possibility of replacing the default ExpiredDocumentsCleaner bean
wolfchkov
force-pushed
the
feature/durable-delete-support
branch
from
bf262a6 to
3a2ff75
Compare
ijusti
approved these changes
Dec 13, 2023
ijusti
approved these changes
Dec 13, 2023
ijusti
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.